MultiDbClient implementation #3696
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…v-multi-db-client
petyaslavova
reviewed
Jul 9, 2025
| if database_config.client_kwargs.get("retry", None) is not None: | ||
| # The retry object is not used in the lower level clients, so we can safely remove it. | ||
| # We rely on command_retry in terms of global retries. | ||
| database_config.client_kwargs.update({"retry": Retry(retries=0, backoff=NoBackoff())}) |
There was a problem hiding this comment.
I think if the user has provided concrete retry configuration we should keep it and add zero retry config only when the retry is not in the kwargs.
| with self._lock: | ||
| if len(self._failures_within_duration) >= self._threshold: | ||
| database.circuit.state = CBState.OPEN | ||
| if self._command_executor and self._command_executor.active_database: |
There was a problem hiding this comment.
Is it possible to have self._command_executor = None here? Or not having an active database?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
Please make sure to review and check all of these items:
NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.
Description of change
Added initial implementation of MultiDBClient that allows to operate on Active-Active databases